Context Navigation

← Previous Ticket
Next Ticket →

Ticket #893 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Numpy incompatible with python -OO

Reported by:	cscott	Owned by:	pierregm
Priority:	normal	Milestone:	1.2.0
Component:	numpy.ma	Version:	none
Keywords:		Cc:

Description

In line 3256 of numpy/ma/core.py, the following code appears:

inner.doc += doc_note("Masked values are replaced by 0.")

This line fails when python is invoked with the -OO option, which removes doc strings to save memory, since inner.doc will be None and a TypeError? will be raised trying to add a string to None. Adding a guard like: 'if inner.doc:' would fix this bug.

Attachments

numpy-OO.patch (3.6 KB) - added by cscott 2 years ago.: Patch to allow numpy to work when -OO option is passed to python.

Change History

in reply to: ↑ 5 Changed 2 years ago by pierregm

Replying to cscott:

{{{ $ python2.5 -OO -c 'import numpy' }}} is a good way to validate that all of the doc issues have been fixed.

That's what I did of course, but I run into other problems:

Traceback (most recent call last):
  File "<string>", line 1, in ?
  File "/usr/lib64/python2.4/site-packages/numpy/__init__.py", line 125, in ?
    import add_newdocs
  File "/usr/lib64/python2.4/site-packages/numpy/add_newdocs.py", line 9, in ?
    from lib import add_newdoc
  File "/usr/lib64/python2.4/site-packages/numpy/lib/__init__.py", line 4, in ?
    from type_check import *
  File "/usr/lib64/python2.4/site-packages/numpy/lib/type_check.py", line 8, in ?
    import numpy.core.numeric as _nx
  File "/usr/lib64/python2.4/site-packages/numpy/core/__init__.py", line 34, in ?
    from numpy.testing import Tester
  File "/usr/lib64/python2.4/site-packages/numpy/testing/__init__.py", line 12, in ?
    from utils import *
  File "/usr/lib64/python2.4/site-packages/numpy/testing/utils.py", line 9, in ?
    from nosetester import import_nose
  File "/usr/lib64/python2.4/site-packages/numpy/testing/nosetester.py", line 88, in ?
    class NoseTester(object):
  File "/usr/lib64/python2.4/site-packages/numpy/testing/nosetester.py", line 292, in NoseTester
    _docmethod(_test_argv, '(testtype)')
  File "/usr/lib64/python2.4/site-packages/numpy/testing/nosetester.py", line 85, in _docmethod
    meth.__doc__ = meth.__doc__ % {'test_header':test_header}
TypeError: unsupported operand type(s) for %: 'NoneType' and 'dict'

Until nosetester is fixed, I'm blind.

I'm using r5708 slightly modified (commenting out the trunc function in umathmodule.c.src that prevents me to compile numpy).

Changed 2 years ago by charris

OK the problem is with assert:

$[charris@f9 ~]$ python -OO
Python 2.5.1 (r251:54863, Jun 15 2008, 18:24:51) 
[GCC 4.3.0 20080428 (Red Hat 4.3.0-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> assert 1 == 0, "bummer"
>>> 
$[charris@f9 ~]$ python
Python 2.5.1 (r251:54863, Jun 15 2008, 18:24:51) 
[GCC 4.3.0 20080428 (Red Hat 4.3.0-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> assert 1 == 0, "bummer"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AssertionError: bummer
>>>

Which probably creates a problem for failUnlessRaises. That function looks to be in TestCase?.

Changed 2 years ago by charris

Ok, I fixed the segfault by changing convolve to explicitly raise a ValueError?. However, there are a number of new errors that now show up running with -OO:

====================================================================== FAIL: Test two arrays with different shapes are found not equal.